[#2889] Fixes for 'Too many files open' error

 * Ensure all file descriptors are closed. Using the with statement ensures
   closure.
 * The main problem was with thousands of unclosed file desciptors from
   tracker_icons mkstemp.
 * Use a prefix 'deluge_ticon.' to identify created tracker_icon tmp files.

1 files changed, 10 insertions, 9 deletions

diff --git a/deluge/log.py b/deluge/log.py
index 0732f84a0..faf2a011f 100644
--- a/deluge/log.py
+++ b/deluge/log.py
@@ -203,15 +203,16 @@ def tweak_logging_levels():
     log = logging.getLogger(__name__)
     log.warn("logging.conf found! tweaking logging levels from %s",
              logging_config_file)
-    for line in open(logging_config_file, "r").readlines():
-        if line.strip().startswith("#"):
-            continue
-        name, level = line.strip().split(":")
-        if level not in levels:
-            continue
-
-        log.warn("Setting logger \"%s\" to logging level \"%s\"", name, level)
-        set_logger_level(level, name)
+    with open(logging_config_file, "r") as _file:
+        for line in _file:
+            if line.strip().startswith("#"):
+                continue
+            name, level = line.strip().split(":")
+            if level not in levels:
+                continue
+
+            log.warn("Setting logger \"%s\" to logging level \"%s\"", name, level)
+            set_logger_level(level, name)
 
 
 def set_logger_level(level, logger_name=None):