summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCalum Lind <calumlind+deluge@gmail.com>2022-05-01 19:32:16 +0100
committerCalum Lind <calumlind+deluge@gmail.com>2022-05-01 20:32:57 +0100
commit61a83bbd20d3a47239b6e2685d15ea19760e0976 (patch)
treea804f2bb682b1a4139faa9a9571a1aec0c85b584
parentbc6611fc0dd1b51dc1e9b816c985c1f71f002798 (diff)
downloaddeluge-61a83bbd20d3a47239b6e2685d15ea19760e0976.tar.gz
deluge-61a83bbd20d3a47239b6e2685d15ea19760e0976.tar.bz2
deluge-61a83bbd20d3a47239b6e2685d15ea19760e0976.zip
[Tests] Remove winreg interface name check
GitHub CI tests on Windows failing for get_windows_interface_name so remove the fragile tests since not a requirement to be this specific with testing whether name exists for these methods relying on standard lib or 3rd-party libs.
-rw-r--r--deluge/tests/test_common.py25
1 files changed, 0 insertions, 25 deletions
diff --git a/deluge/tests/test_common.py b/deluge/tests/test_common.py
index afd519356..e5027ebca 100644
--- a/deluge/tests/test_common.py
+++ b/deluge/tests/test_common.py
@@ -108,33 +108,10 @@ class TestCommon:
assert is_ipv6('2001:db8::')
assert not is_ipv6('2001:db8:')
- def get_windows_interface_name(self):
- import winreg
-
- # find a network card in the registery
- with winreg.OpenKey(
- winreg.HKEY_LOCAL_MACHINE,
- r'SOFTWARE\Microsoft\Windows NT\CurrentVersion\NetworkCards',
- ) as key:
- assert winreg.QueryInfoKey(key)[0] > 0 # must have at least 1 network card
- network_card = winreg.EnumKey(key, 0)
- # get GUID of network card
- with winreg.OpenKey(
- winreg.HKEY_LOCAL_MACHINE,
- fr'SOFTWARE\Microsoft\Windows NT\CurrentVersion\NetworkCards\{network_card}',
- ) as key:
- for i in range(1):
- value = winreg.EnumValue(key, i)
- if value[0] == 'ServiceName':
- interface_name = value[1]
- return interface_name
-
def test_is_interface_name(self):
if windows_check():
- interface_name = self.get_windows_interface_name()
assert not is_interface_name('2001:db8:')
assert not is_interface_name('{THIS0000-IS00-ONLY-FOR0-TESTING00000}')
- assert is_interface_name(interface_name)
else:
assert is_interface_name('lo')
assert not is_interface_name('127.0.0.1')
@@ -142,9 +119,7 @@ class TestCommon:
def test_is_interface(self):
if windows_check():
- interface_name = self.get_windows_interface_name()
assert is_interface('127.0.0.1')
- assert is_interface(interface_name)
assert not is_interface('127')
assert not is_interface('{THIS0000-IS00-ONLY-FOR0-TESTING00000}')
else: